support direct table filter link #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplanelad
added
kind/new-feature
rs324
reviewed
Sep 1, 2020
ui/src/utils/History.js
Outdated
| * @returns {string} Param value from url | ||
| */ | ||
| export const getHistory = (query) => { | ||
| export const getHistory = (query, defaultReturn = null) => { |
There was a problem hiding this comment.
Please chagne to defaultValue
| const classes = useStyles(); | ||
| // eslint-disable-next-line |
| @@ -150,7 +150,7 @@ const FilterBar = ({ | |||
| } | |||
| }); | |||
|
|
|||
| updateFilters(filters); | |||
| setFilters(filters); | |||
There was a problem hiding this comment.
update filters updates the history as well incase of bad filter passed at the url.
There was a problem hiding this comment.
what is a bad filter? this code removes the table filters.
If we have a "bad" filter the code will not use them
| const classes = useStyles(); | ||
| // eslint-disable-next-line | ||
| const [tableFilters, setTableFilters] = useTableFilters({}); |
There was a problem hiding this comment.
Where do you use tableFilters ? (I only see you use setTableFilters)
rs324
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/UI Feature
What this PR does / why we need it:
support direct table filter link
for example, when the user goes to: /?filters=resource:aws_apigateway&executionId=general_1598464963&sortColumn=Name&direction=asc&search=test&rows=100&page=1
the resource table component will set the get parameters:
sortColumn
direction
search
rows
with the URL values