-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci + gofmt and fix the errors #78
Conversation
collector/aws/run.go
Outdated
metrics, found := app.metrics["ec2"] | ||
if !found { | ||
return nil | ||
log.WithField("resource_name", "ec2").Info("resource not configure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource not configure -> resource was not configured
collector/aws/run.go
Outdated
resource, found := app.resources["iamLastActivity"] | ||
if !found { | ||
return nil | ||
log.WithField("resource_name", "iamLastActivity").Info("resource not configure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above "not confiure" -> "was not configured"
collector/aws/run.go
Outdated
metrics, found := app.metrics["elb"] | ||
if !found { | ||
return nil | ||
log.WithField("resource_name", "elb").Info("resource not configure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above for the text.
resource, found := app.resources["iamLastActivity"] | ||
if !found { | ||
return nil | ||
log.WithField("resource_name", "iamLastActivity").Info("resource not configure") | ||
return | ||
} | ||
|
||
if _, ok := app.global["iamLastActivity"]; ok { | ||
log.Debug(fmt.Sprintf("skip %s detection", resource.Description)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip -> skipping
collector/aws/run.go
Outdated
metrics, found := app.metrics["elbv2"] | ||
if !found { | ||
return nil | ||
log.WithField("resource_name", "elbv2").Info("resource not configure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/Feature
What this PR does / why we need it:
Implement golangci-lint and gofmt + fix recomandation