Skip to content

Commit

Permalink
Merge pull request mrniko#14 from YoonsooChang/yoonsoo
Browse files Browse the repository at this point in the history
Fix Syntax Errors
  • Loading branch information
YoonsooChang committed Jun 6, 2020
2 parents 95773d0 + 941b67d commit a6e04ab
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 343 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.util.UUID;

import com.corundumstudio.socketio.listener.ClientListeners;
import com.corundumstudio.socketio.listener.ListenerManager;

/**
* Fully thread-safe.
Expand Down Expand Up @@ -47,4 +48,6 @@ public interface SocketIONamespace {
*/
SocketIOClient getClient(UUID uuid);

ListenerManager getListenerManager();

}
33 changes: 20 additions & 13 deletions src/main/java/com/corundumstudio/socketio/SocketIOServer.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class SocketIOServer implements ClientListeners {

private final NamespacesHub namespacesHub;
private final SocketIONamespace mainNamespace;

private ListenerManager listenerManager;
private SocketIOChannelInitializer pipelineFactory = new SocketIOChannelInitializer();

private EventLoopGroup bossGroup;
Expand All @@ -62,6 +62,7 @@ public SocketIOServer(Configuration configuration) {
this.configCopy = new Configuration(configuration);
namespacesHub = new NamespacesHub(configCopy);
mainNamespace = addNamespace(Namespace.DEFAULT_NAME);
listenerManager = mainNamespace.getListenerManager();
}

public void setPipelineFactory(SocketIOChannelInitializer pipelineFactory) {
Expand Down Expand Up @@ -221,50 +222,56 @@ public Configuration getConfiguration() {

@Override
public void addMultiTypeEventListener(String eventName, MultiTypeEventListener listener, Class<?>... eventClass) {
mainNamespace.addMultiTypeEventListener(eventName, listener, eventClass);
listenerManager.addMultiTypeEventListener(eventName, listener, eventClass);
}

@Override
public <T> void addEventListener(String eventName, Class<T> eventClass, DataListener<T> listener) {
mainNamespace.addEventListener(eventName, eventClass, listener);
listenerManager.addEventListener(eventName, eventClass, listener);
}

@Override
public void addEventInterceptor(EventInterceptor eventInterceptor) {
mainNamespace.addEventInterceptor(eventInterceptor);
listenerManager.addEventInterceptor(eventInterceptor);

}


@Override
public void removeAllListeners(String eventName) {
mainNamespace.removeAllListeners(eventName);
listenerManager.removeAllListeners(eventName);
}

@Override
public void addDisconnectListener(DisconnectListener listener) {
mainNamespace.addDisconnectListener(listener);
listenerManager.addDisconnectListener(listener);
}

@Override
public void addConnectListener(ConnectListener listener) {
mainNamespace.addConnectListener(listener);
listenerManager.addConnectListener(listener);
}

@Override
public void addPingListener(PingListener listener) {
mainNamespace.addPingListener(listener);
listenerManager.addPingListener(listener);
}

@Override
public void addListeners(Object listeners) {
mainNamespace.addListeners(listeners);
listenerManager.addListeners(listeners);
}

@Override
public void addListeners(Object listeners, Class<?> listenersClass) {
mainNamespace.addListeners(listeners, listenersClass);
}
// @Override
// public void addListeners(Object listeners, Class<?> listenersClass) {
// listenerManager.addListeners(listeners, listenersClass);
// }

@Override
public void addListeners(Object listeners, Class<?> listenersClass) {
listenerManager.addListeners(listeners, listenersClass);

}


}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.corundumstudio.socketio.listener;

import com.corundumstudio.socketio.namespace.Namespace;

public interface ClientListeners {

Expand All @@ -35,5 +36,6 @@ public interface ClientListeners {
void addListeners(Object listeners, Class<?> listenersClass);

void removeAllListeners(String eventName);


}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.corundumstudio.socketio.SocketIOClient;
import com.corundumstudio.socketio.annotation.ScannerEngine;
import com.corundumstudio.socketio.namespace.EventEntry;
import com.corundumstudio.socketio.namespace.Namespace;
import com.corundumstudio.socketio.protocol.JsonSupport;
import com.corundumstudio.socketio.transport.NamespaceClient;

Expand All @@ -23,7 +24,8 @@ public class ListenerManager implements ClientListeners {
private final JsonSupport jsonSupport;
private final ExceptionListener exceptionListener;
private final AckMode ackMode;

private final Namespace namespace;

private final ScannerEngine engine = new ScannerEngine();

private final ConcurrentMap<String, EventEntry<?>> eventListeners = PlatformDependent.newConcurrentHashMap();
Expand All @@ -34,7 +36,8 @@ public class ListenerManager implements ClientListeners {
private final Queue<EventInterceptor> eventInterceptors = new ConcurrentLinkedQueue<EventInterceptor>();


public ListenerManager(JsonSupport jsonSupport, String namespaceName, ExceptionListener exceptionListener, AckMode ackMode) {
public ListenerManager(Namespace namespace, JsonSupport jsonSupport, String namespaceName, ExceptionListener exceptionListener, AckMode ackMode) {
this.namespace = namespace;
this.jsonSupport = jsonSupport;
this.namespaceName = namespaceName;
this.exceptionListener = exceptionListener;
Expand Down Expand Up @@ -107,7 +110,7 @@ public void addListeners(Object listeners) {
@Override
public void addListeners(Object listeners, Class<?> listenersClass) {
// TODO Auto-generated method stub
engine.scan(this, listeners, listenersClass);
engine.scan(namespace, listeners, listenersClass);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public Namespace(String name, Configuration configuration) {
this.name = name;
this.storeFactory = configuration.getStoreFactory();

listenerManager = new ListenerManager(configuration.getJsonSupport(), name,
listenerManager = new ListenerManager(this, configuration.getJsonSupport(), name,
configuration.getExceptionListener(), configuration.getAckMode());
}

Expand Down Expand Up @@ -287,4 +287,10 @@ public SocketIOClient getClient(UUID uuid) {
return allClients.get(uuid);
}

@Override
public ListenerManager getListenerManager() {
// TODO Auto-generated method stub
return listenerManager;
}

}

0 comments on commit a6e04ab

Please sign in to comment.