Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all Lor Match v1 endpoints #33

Merged
merged 4 commits into from
Oct 24, 2020
Merged

Conversation

simivar
Copy link
Owner

@simivar simivar commented Oct 24, 2020

Implement all Lor Match v1 endpoints: #11

@simivar simivar added this to the 1.0.0 milestone Oct 24, 2020
@simivar simivar added the enhancement New feature or request label Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #33 into main will increase coverage by 0.10%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #33      +/-   ##
============================================
+ Coverage     94.75%   94.85%   +0.10%     
- Complexity      232      261      +29     
============================================
  Files            45       50       +5     
  Lines           724      816      +92     
============================================
+ Hits            686      774      +88     
- Misses           38       42       +4     
Impacted Files Coverage Δ Complexity Δ
src/Riot/API.php 0.00% <0.00%> (ø) 19.00 <2.00> (+2.00)
src/Riot/API/Version1/LorMatch.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Riot/DTO/InfoDTO.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Riot/DTO/LorPlayerDTO.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Riot/DTO/MatchDTO.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Riot/DTO/MetadataDTO.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2946f73...d15626a. Read the comment docs.

@simivar simivar merged commit 707ebbb into main Oct 24, 2020
@simivar simivar deleted the feature/implement-all-lor-match branch October 24, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants