Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all Clash v1 endpoint #39

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

simivar
Copy link
Owner

@simivar simivar commented Oct 26, 2020

Implement all Clash v1 endpoint: #7

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #39 into main will decrease coverage by 0.01%.
The diff coverage is 97.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #39      +/-   ##
============================================
- Coverage     97.37%   97.36%   -0.02%     
- Complexity      627      669      +42     
============================================
  Files            85       93       +8     
  Lines          2133     2273     +140     
============================================
+ Hits           2077     2213     +136     
- Misses           56       60       +4     
Impacted Files Coverage Δ Complexity Δ
src/Riot/API.php 0.00% <0.00%> (ø) 25.00 <2.00> (+2.00)
src/Riot/API/Version1/Clash.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/Riot/Collection/Clash/PlayerDTOCollection.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../Riot/Collection/Clash/TournamentDTOCollection.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../Collection/Clash/TournamentPhaseDTOCollection.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Riot/DTO/Clash/PlayerDTO.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/Riot/DTO/Clash/TeamDTO.php 100.00% <100.00%> (ø) 10.00 <10.00> (?)
src/Riot/DTO/Clash/TournamentDTO.php 100.00% <100.00%> (ø) 7.00 <7.00> (?)
src/Riot/DTO/Clash/TournamentPhaseDTO.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7576295...6c9f141. Read the comment docs.

@simivar simivar merged commit d9dc03e into main Oct 26, 2020
@simivar simivar deleted the feature/implement-all-clash branch October 26, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants