Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with cancel and done completion blocks #29

Closed
Gargo opened this issue Jul 25, 2023 · 0 comments
Closed

Problem with cancel and done completion blocks #29

Gargo opened this issue Jul 25, 2023 · 0 comments

Comments

@Gargo
Copy link

Gargo commented Jul 25, 2023

In my case I need to perform different actions for cancel and done completion blocks. It could be simply implemented if your libary had one block for 2 actions with variable "isCancelled" or "isSuccess" or if there were 2 separate blocks for actions.

Instead your library has doneHandler and dismissHandler. In case of cancel dismissHandler is called only, in case of done they are both called and I need somehow to check if "dismiss" is called separately or immediately after "done"
UriyDevyataev added a commit that referenced this issue Aug 29, 2023
@UriyDevyataev
fix #29 doneHandler deprecated
4ee5b22 
replace viewDidDisappear to viewWillDisappear for call self.dismissHandler
UriyDevyataev added a commit that referenced this issue Aug 30, 2023
@UriyDevyataev
fix #29 replace deprecated with unavailable for doneHandler
32c4d00
ilia3546 pushed a commit that referenced this issue Aug 30, 2023
@UriyDevyataev
fix #29 doneHandler deprecated (#33)
596a57f 
* fix #29 doneHandler deprecated

replace viewDidDisappear to viewWillDisappear for call self.dismissHandler

* fix #29 replace deprecated with unavailable for doneHandler
UriyDevyataev added a commit that referenced this issue Aug 30, 2023
@UriyDevyataev
fix #29 move enum DismissAction to FastisController
adc93e9
ilia3546 added a commit that referenced this issue Aug 30, 2023
@UriyDevyataev @ilia3546
fix #29 move enum DismissAction to FastisController (#35)
e073dfc 
* fix #29 move enum DismissAction to FastisController

* Update Controller.swift

---------

Co-authored-by: Ilya Kharlamov <ilia3546@me.com>
UriyDevyataev added a commit that referenced this issue Sep 7, 2023
@UriyDevyataev
fix #29 add indication for current day
2d6ffc0 
- change DayCell struct to class
- child class TodayCell from DayCell
UriyDevyataev added a commit that referenced this issue Sep 7, 2023
@UriyDevyataev
fix #29 add indication for current day
402ccf2
ilia3546 pushed a commit that referenced this issue Sep 26, 2023
@UriyDevyataev @ilia3546
fix #29 add indication for current day
ab5f511 
- change DayCell struct to class
- child class TodayCell from DayCell
ilia3546 pushed a commit that referenced this issue Sep 26, 2023
@UriyDevyataev @ilia3546
fix #29 add indication for current day
c2d1df8
ilia3546 pushed a commit that referenced this issue Sep 26, 2023
@UriyDevyataev @ilia3546
fix #29 add indication for current day
2a4d0f5
ilia3546 pushed a commit that referenced this issue Sep 26, 2023
@UriyDevyataev
fix #29 add indication for current day (#36)
bb39d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gargo