Handled no prefix day on Shavuos when israel=True.

simlist · Feb 28, 2023 · 7b96339 · 7b96339
1 parent 7d0adc8
commit 7b96339
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/pyluach/dates.py b/src/pyluach/dates.py
@@ -204,8 +204,8 @@ def _day_of_holiday(self, israel, hebrew=False):
         name = utils._festival_string(self, israel)
         if name is not None:
             holiday = utils.Days(name)
-            # if holiday is utils.Days.SHAVUOS and israel:
-            #     return ''
+            if holiday is utils.Days.SHAVUOS and israel:
+                return ''
             first_day = utils._first_day_of_holiday(holiday)
             if first_day:
                 day = HebrewDate(self.year, *first_day) - self + 1

diff --git a/tests/test_dates.py b/tests/test_dates.py
@@ -259,9 +259,9 @@ def test_festival(self):
 
     def test_day_of_holiday(self):
         assert HebrewDate(5783, 12, 14)._day_of_holiday(israel=False) == ''
-        # shavuos = HebrewDate(5783, 3, 6)
-        # assert shavuos.holiday(prefix_day=True) == '1 Shavuos'
-        # assert shavuos.holiday(israel=True, prefix_day=True) == 'Shavuos'
+        shavuos = HebrewDate(5783, 3, 6)
+        assert shavuos.holiday(prefix_day=True) == '1 Shavuos'
+        assert shavuos.holiday(israel=True, prefix_day=True) == 'Shavuos'
 
 
 def test_to_pydate():