Fix attached index not resolving

simolus3 · Dec 4, 2023 · 27b459d · 27b459d
1 parent 09d450e
commit 27b459d
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 5 deletions.
diff --git a/drift/example/main.g.dart b/drift/example/main.g.dart
diff --git a/drift_dev/lib/src/analysis/driver/driver.dart b/drift_dev/lib/src/analysis/driver/driver.dart
@@ -230,7 +230,9 @@ class DriftAnalysisDriver {
     assert(state.discovery != null || state.cachedDiscovery != null);
     assert(id.libraryUri == state.ownUri);
 
-    if (!state.elementIsAnalyzed(id)) {
+    if (state.elementIsAnalyzed(id)) {
+      return state.analysis[id]?.result;
+    } else {
       final resolver = DriftResolver(this);
 
       try {
@@ -241,10 +243,10 @@ class DriftAnalysisDriver {
 
           if (_isTesting) rethrow;
         }
+
+        return null;
       }
     }
-
-    return null;
   }
 
   /// Resolves elements in a file under the given [uri] by doing all the

diff --git a/drift_dev/test/writer/table_writer_test.dart b/drift_dev/test/writer/table_writer_test.dart
@@ -66,6 +66,34 @@ class Tags extends Table {
     }, result.dartOutputs, result.writer);
   });
 
+  test('generates index attached to table in same file', () async {
+    // Regression test for https://github.com/simolus3/drift/discussions/2766
+    final result = await emulateDriftBuild(
+      inputs: {
+        'a|lib/a.dart': '''
+import 'package:drift/drift.dart';
+
+@TableIndex(name: 'tag_id', columns: {#id})
+class Tags extends Table {
+  IntColumn get id => integer().autoIncrement()();
+}
+
+@DriftDatabase(tables: [Tags])
+class MyDatabase {}
+''',
+      },
+    );
+
+    checkOutputs({
+      'a|lib/a.drift.dart': decodedMatches(allOf(
+        contains(
+          "Index tagId = Index('tag_id', 'CREATE INDEX tag_id ON tags (id)')",
+        ),
+        contains('allSchemaEntities => [tags, tagId]'),
+      )),
+    }, result.dartOutputs, result.writer);
+  });
+
   test('generates index attached to table in modular build', () async {
     final result = await emulateDriftBuild(
       inputs: {