-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option use_sql_column_name_as_json_key
#2910
feat: Add option use_sql_column_name_as_json_key
#2910
Conversation
For the tests, I see you have an |
Thanks!
We have a simpler way of testing all stages of the generator in a unit test. You can take a look at this test as inspiration, |
''')), | ||
}, writer.dartOutputs, writer.writer); | ||
}, | ||
tags: 'analyzer', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this tag, it was also in the test you suggested me to look at. Should I leave it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it gives the test a little longer to run because the analyzer is sometimes a bit inconsistent in its timing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks!
''')), | ||
}, writer.dartOutputs, writer.writer); | ||
}, | ||
tags: 'analyzer', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it gives the test a little longer to run because the analyzer is sometimes a bit inconsistent in its timing.
Should close #2847