Support custom row classes for manager #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3004--moor.netlify.app |
|
This may make it harder to add features later, but nothing impossible. |
dickermoshe
approved these changes
May 12, 2024
dickermoshe
requested changes
May 12, 2024
dickermoshe
approved these changes
May 12, 2024
|
Thanks for taking a look and fixing the assert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating manager classes for tables with existing row classes. At the moment, the only thing I had to change was removing the
DataClassgeneric bound in the runtime.@dickermoshe, can you check whether you need the
extends DataClassbound for future manager changes? If not I think this sounds like a fairly easy way to port manager code over to more tables.Closes #2989.