Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

parse hex fail #81

Closed
Kleak opened this issue Mar 9, 2020 · 3 comments
Closed

parse hex fail #81

Kleak opened this issue Mar 9, 2020 · 3 comments

Comments

@Kleak
Copy link

Kleak commented Mar 9, 2020

this seems wrong https://github.com/simolus3/web3dart/blob/master/lib/src/crypto/formatting.dart#L59

this transform hex into int but there is not radix here, this lead to parsing error sometime i think

it should be :

int.parse(strip0x(hex), radix: 16);
@simolus3
Copy link
Owner

Oh no, how could I have missed that 😲

I'll release the fix to pub soon, thanks for the report.

@Marcel2508
Copy link

Any Progress on this? When do you plan to publish the fix to pub?

@simolus3
Copy link
Owner

simolus3 commented Apr 7, 2020

This is included in the current pre-release of 2.0.0.-dev, which is on pub already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants