New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification and Improve tray icon #7

Merged

simon-fraser merged 3 commits into simon-fraser:master from dotenorio:master

Oct 9, 2018

Contributor

dotenorio commented Oct 8, 2018

Notification now show better information without breaking lines, bullets and 'SnoreToast' string. (https://i.imgur.com/P7qci2m.png)
Click tray adjust to best ux where user just minimized player.
Add right click to execute About and Quit faster.

😍 😍

dotenorio added 3 commits

October 8, 2018 13:18


          fix: notification; feat: improve tray;

6a01e4b


          fix: package.json

34768be


          fix: windows installer command on package.json (remove space on name)

5440cd2

dotenorio commented

View reviewed changes

index.js

    
            @@ -148,9 +176,9 @@ function playStatus () {
          
                  if (mainWindow) {

                    mainWindow.webContents.executeJavaScript(`

                      var ipcRenderer = require('electron').ipcRenderer

                      var status = (document.querySelector('.play-pause-button').title === 'Pause')? 'Playing' : 'Paused'

                      var status = (!document.querySelector('.play-pause-button').title.includes('Paus')) ? 'Playing' : 'Paused'

Contributor Author

dotenorio Oct 8, 2018

I added this verification to work in pt-br also

simon-fraser merged commit 4e8f169 into simon-fraser:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment