Firat attempt at adding some business logic.. #8
Conversation
simonblund
added this to the Basic information should be handled in the application milestone
|
Hey, Nice work on the implementations. Seems to be sticking to the books of how Spring works. A few thoughts here.
How do you want to go ahead with this merge? Continue working in the branch or start a new one, because I would vote to not pass this PR as it stands now. I'd like a second opinion @limolback2016 please. Cheers |
|
I concur with your comment regarding NyA, theoretically we could make that a scheduled task instead. Student-service pulling NyA for new students. I'll have to take a closer look at the mock API before continuing. However for testing purposes an easy to use endpoint to create students is vital. |
|
In fact I think a POST request to mock-services will create a student... it's an in-memory db just manipulated with REST calls and not Repository-classes... which makes me wonder if Spring HTTP requests module/dependency can act like a Repository. Like an ORM around an API. |
|
resolves #9 |
| @@ -9,10 +9,12 @@ dependencies { | |||
| implementation 'org.springframework.boot:spring-boot-starter-web' | |||
| implementation 'org.springframework.cloud:spring-cloud-starter-circuitbreaker-resilience4j' | |||
| implementation 'org.springframework.cloud:spring-cloud-starter-openfeign' | |||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | |||
There was a problem hiding this comment.
probably drop these dependencies to JPA and h2 database.
| services: | ||
| mock-service: | ||
| url: http://localhost:8282 |
There was a problem hiding this comment.
add a newline at end of file.
|
Good work! Made a squash merge to master. |
|
Done. Made the merge. |
resolves #7
resolves #6
Take a close look at this request, do we need to keep more information in the student object. The main redesign is that we now keep base information about the student in the microservice for convinience for future development of the project.