Adds workaround for caret not appearing on iOS 17 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has made it through app review and is available in Runestone Text Editor 1.3.20: https://apps.apple.com/dk/app/runestone-text-editor/id1548193893 |
eliperkins
added a commit
to eliperkins/Runestone
that referenced
this pull request
Nov 30, 2023
This will still mean that the bug addressed in simonbs#314 will persist, but will allow consumers bound to older Xcode versions to continue to update the rest of the codebase and its dependencies
simonbs
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Enable backwards compatibility when compiling with Xcode 14 This will still mean that the bug addressed in #314 will persist, but will allow consumers bound to older Xcode versions to continue to update the rest of the codebase and its dependencies * Add end-of-file new lines * Safe-guard usage as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue where the caret does not appear when editing starts on iOS 17 until the user have tapped the text view again.
This is a regression in UITextInteraction and other developers of text editors are seeing the same issue.
I have filed this as feedback to Apple on July 15th, 2023 but have yet to hear back from them (FB12622609).
The issue seems to be caused by the UITextSelectionDisplayInteraction that is automatically installed by UITextInteraction not being active initially.