File::extname Ruby 2.7 behavior

simonc · Jan 7, 2020 · 621b81b · 621b81b
1 parent 9d97e17
commit 621b81b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/memfs.rb b/lib/memfs.rb
@@ -29,6 +29,10 @@ def self.ruby_version_gte?(version) # :nodoc:
     Gem::Version.new(RUBY_VERSION) >= Gem::Version.new(version)
   end
 
+  def self.windows?
+    /mswin|bccwin|mingw/ =~ RUBY_PLATFORM
+  end
+
   require 'memfs/file_system'
   require 'memfs/dir'
   require 'memfs/file'

diff --git a/spec/memfs/file_spec.rb b/spec/memfs/file_spec.rb
@@ -527,9 +527,16 @@ module MemFs
       end
 
       context 'when the period is the last character in path' do
-        it 'returns an empty string' do
-          extname = described_class.extname('test-subject.')
-          expect(extname).to eq ''
+        if MemFs.ruby_version_gte?('2.7') && !MemFs.windows?
+          it 'returns a period' do
+            extname = described_class.extname('test-subject.')
+            expect(extname).to eq '.'
+          end
+        else
+          it 'returns an empty string' do
+            extname = described_class.extname('test-subject.')
+            expect(extname).to eq ''
+          end
         end
       end
     end