Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regress nx version to 13.10.6 #90

Merged
merged 27 commits into from
Jan 23, 2023
Merged

Regress nx version to 13.10.6 #90

merged 27 commits into from
Jan 23, 2023

Conversation

simondotm
Copy link
Owner

@simondotm simondotm commented Jan 8, 2023

Decided that we may need to release a plugin version for each major release of Nx, so this PR builds the plugin at Nx 13.10.6 which will be the minimum Nx version for new releases.

Various reasons for this:

  1. It is not unclear if we can maintain backwards compatibility for the plugin across Nx version, because the API changes so often. The only option we have is to release a plugin version to match each Nx version.
  2. Each new Nx release tends to upgrade internal dependencies - tsc, tslib, Angular etc. and other projects may not be ready to take Angular 14/Angular 15 etc.
  3. If we create branches for different plugin versions, we can patch if necessary.

The compat:test tool now runs a test matrix across Nx versions and Plugin versions to indicate compatibility from Nx 13.10.6 onwards.

Also, the peerDeps in the plugin are now minimized to just:

  "peerDependencies": {
    "nx": ">= 13.10.6",
    "@nrwl/workspace": ">= 13.10.6"
  }

Which are the two core dependencies for every Nx workspace.

It is the plugin initialiser that will now add the Nx plugins it needs, using the version of the host workspace:

 '@nrwl/devkit'
 '@nrwl/linter'
 '@nrwl/jest'
 '@nrwl/node'
 '@nrwl/js'

@simondotm simondotm merged commit 9f32117 into main Jan 23, 2023
@simondotm simondotm deleted the regress-nx-version branch January 23, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant