-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable cache #33
Comments
Hi, sorry for the delay. This requires more details. By disabling cache, what do you mean exactly? At the current time the hook is executed whenever the configuration (url and other request options) change. It wouldn't make sense to re-execute the hook every time that the component renders. So I presume that what you're saying is, when the component is re-mounted, which would execute the hook, instead of using the cache, which is what happens by default, skip it and execute the request again. I'm not sure what kind of benefit this provides though, because usually you wouldn't use component (re)mounting to decide when to execute requests. Can you clarify your scenario? |
Meanwhile, I went ahead and added tests by building on top of your PR here: #37. I'm still not sure exactly what value this provides though, I'd like to hear your thoughts based on the previous comment. |
For a given URL and request options, APIs may not always return the same data. Data may evolve over time, and an application might require to always get the latest data. Unless I am mistaken it seems impossible to use the hook if for instance, we run it on a homepage that would call, let's say |
When I use Apollo Client, I prefer to disable the cache completely with a |
Thanks for confirming @verekia. Note that this is already possible by using the
You would achieve the same as with this new option we're discussing. I appreciate it's additional code you have to write though. |
Thank you. Well it's true that it would work, but for me one of the main added value of this kind of network hook is to not have to use |
released in version 1.4.0 |
Hi, thank you for the hook! Loving it.
I am running into a blocker though, as I am trying to use
useAxios
but it seems like it's impossible to disable caching for normal (not refetched) calls.My API endpoint doesn't always return the same thing, which is a very common situation.
In my particular case, when I log out,
useAxios
still returns all the same data as when the user was logged in as I navigate through the app instead of allowing me to show a "you are not logged in" message.Having the
useCache
option on the normal hook call seems like it would be a simple fix (rather than implementing a full fetch policy).To be honest, it seems like an absolutely necessary feature 😅.
The text was updated successfully, but these errors were encountered: