Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with --gte=100 returning exit code 1 #122

Closed
etienne-ditchlabs opened this issue Aug 11, 2022 · 1 comment
Closed

Issue with --gte=100 returning exit code 1 #122

etienne-ditchlabs opened this issue Aug 11, 2022 · 1 comment
Labels

Comments

@etienne-ditchlabs
Copy link

Currently as per documentation:

If you pass the --gte=value flag you will get an exitCode 0 or 1 based on resulting coverage >= value expression

However the current code is > and not >=

process.exitCode = result > min ? 0 : 1;

Current issue: Passing --gte=100 will return 1 even if lcov-total returns 100%.

Should be:
process.exitCode = result >= min ? 0 : 1;

simonecorsi pushed a commit that referenced this issue Jan 10, 2023
## [2.1.1](v2.1.0...v2.1.1) (2023-01-10)

### Bug Fixes

* gte 100 exiting with 1 ([79e70ac](79e70ac)), closes [#122](#122)
@simonecorsi
Copy link
Owner

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants