Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to flatted #4

Closed

Conversation

lorenzorapetti
Copy link

Closes #3

@lorenzorapetti lorenzorapetti mentioned this pull request Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #4 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   98.52%   98.57%   +0.04%     
==========================================
  Files           1        1              
  Lines          68       70       +2     
==========================================
+ Hits           67       69       +2     
  Misses          1        1
Impacted Files Coverage Δ
index.js 98.57% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fba995...7ac0a88. Read the comment docs.

@simonepri
Copy link
Owner

simonepri commented Dec 23, 2018

Hi @loryman, I think that maybe we can remove the support for circular JSON. (And remove the dependency completely)
I don't see any real advantage for having the library be able to parse a circular structure.

What do you think?
Thank you for the help!

@lorenzorapetti
Copy link
Author

Hi @loryman, I think that maybe we can remove the support for circular JSON. (And remove the dependency completely)
I don't see any real advantage for having the library be able to parse a circular structure.

That's fine with me! Although we still have to preserve the major version bump. If we decide to go this way i can commit the changes with a section in the README with the explanation.

Thank you for the help!

No problem :)

@simonepri
Copy link
Owner

Thank you for your effort!
I've found time to improve both the implementation and the tests for the package.
Let me know if you find any problem with the new version.

Changes in v2.0.0:

  • Removed support for circular JSON stringification and removed circular-json dependency.
  • The default value provided in the get function is now returned as is without being stringified.
  • Values like Infinity, NaN, undefined can now be stringified/parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants