Add buildOptions support to buildSync #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aexmachina what do you think? |
simonexmachina
approved these changes
Nov 14, 2016
| @@ -339,6 +339,9 @@ Be aware that `assoc()` is an async function, so it can't be used with `buildSyn | |||
|
|
|||
| ```javascript | |||
| var doc = factory.buildSync('post', {title: 'Foo'}); | |||
|
|
|||
| // or with buildOptions | |||
| var doc = factory.buildSync('post', { title: 'Foo' }, { veryLong: true }); | |||
There was a problem hiding this comment.
Code formatting is inconsistent with the line above.
|
Thanks. However this version is out of date now - v4 is in beta now and should be considered the current version. @chetanism and I are just finding it hard to get it finished and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed arbitrary that it didn't support it. Initially was trying to chase down a bug affecting ObjectAdapter and buildOptions from version 3.1 but seems to be fixed in the latest master.