Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and travis #35

Merged

Conversation

nakamorichi
Copy link
Contributor

No description provided.

@nakamorichi
Copy link
Contributor Author

@simonguest @briananderson1222 I fixed some issues caused by deprecations.

"mongodb": "^2.1.11",
"mongoose": "^4.4.9"
"mockgoose": "^7.0.0",
"mongoose": "^4.8.6"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed as both a dev dependency and peer dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Peer dependency tells for the library consumer that he should provide such dependency. Dev dependencies are not installed when you npm install a package. The reason why there may not have been problem often in this case is probably because the library consumer already has added mongoose dependency. Nevertheless, mongoose is also a production dependency, and in order to avoid weird version mismatch problems between swagger-mongoose and the consuming project, it is best to have it as a peer dependency so that the library consumer can decide the actual version.

http://stackoverflow.com/questions/18875674/whats-the-difference-between-dependencies-devdependencies-and-peerdependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants