Update method to avoid clash with laravel cashier #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently both billable and payable implement the same pay method. This can break applications that can have users that will receive and pay on the platform in case of affiliate links for example This is a breaking change
gaoxinhui
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently applications can use both stripe connect to split payment between users and there's use cases where the same users that will receive those transfers could also be subscribers of a subscription or can buy goods on the platform or website.
Because of this there's cases where we will want Users to be both payable and billable (using laravel Cashier)
In this specific case we could have method clash because Cashier currently implements the pay method in order to charge customers.
This PR aims to solve this method name clashing, also aligns the name with the conventional name that stripe uses, making it easier to use.
It also updates the Readme examples to avoid misusage
This is a breaking change