feat: add support for background image URL #1
Conversation
Adds the ability to set a background image URL. Added a new test in `test_with_url.php` which also shows how it can be used. Image used in the test is in public domain 🫡
src/Image.php
Outdated
| if (!filter_var($backgroundURL, FILTER_VALIDATE_URL)) { | ||
| throw new \InvalidArgumentException('URL is not valid'); | ||
| } | ||
|
|
||
| $imageInfo = @getimagesize($backgroundURL); | ||
| if (!$imageInfo) { | ||
| throw new \InvalidArgumentException('URL doesn\'t point to an image'); | ||
| } |
There was a problem hiding this comment.
Some small sanity checks to make sure it's a valid image link.
src/Traits/RendersImages.php
Outdated
| $panel->resize($this->width, $this->height, function ($constraint) { | ||
| $constraint->aspectRatio(); | ||
| $constraint->upsize(); | ||
| }); |
There was a problem hiding this comment.
Resize the image so it looks properly in place
There was a problem hiding this comment.
This looks great! Thanks so much.
Apologies are in order from me though. Before I had a chance to review and merge this, I had embarked on a sizable refactor, so there are a couple of merge conflicts now
It shouldn't be too drastic to fix - basically I moved rendering to happen in the Layout rather than in the Image and renamed the trait from RendersImages to RendersFeatures.
This means that properties from the Image are now accessible via the $config property on the Layout, i.e.:
- $this->backgroundUrl
+ $this->config->backgroundUrlLet me know if you have any trouble and I'll take a look. Excited to get this merged as it will be a really nice addition so early on!
Co-authored-by: Sven Luijten <11269635+svenluijten@users.noreply.github.com>
This commit removes the following test files: - `tests/test.png` - `tests/test_background_url.png` - `tests/test_with_url.php` These files are no longer needed and have been deleted.
It should all be working again. |
Adds the ability to set a background image from a URL.
Includes some small sanity checks to make sure it's an actual link that points to an image.
Added a new test in
test_with_url.phpwhich also shows how it can be used. Image used in the test is in public domain.If you'd like to see any changes to my implementation, let me know and I'll work on it.