Another font and another background #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Theme enum to the root for 'easier access' Change the AbstractTheme into a normal class - we don't need it to be abstract
simonhamp
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was going to be a simple PR to add an image and a font, but I realised a few things whilst testing these additions out, so now this is a⚠️ breaking change, but I think it's for the best at this early stage... hopefully this will be the last breaking change before v1!
Added
GridMebackground (specifically for @Stillat. Tweet)RobotoSlabfontHere they are in action
Changed
AbstractThemein favour of simply instantiating theThemeclass.If you were extending
AbstractTheme, now you can simply create an instance ofSimonHamp\TheOg\Theme\Themeinstead.