Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite #5

Merged
merged 8 commits into from
Jan 7, 2024
Merged

Add test suite #5

merged 8 commits into from
Jan 7, 2024

Conversation

svenluijten
Copy link
Contributor

@svenluijten svenluijten commented Jan 6, 2024

This PR:

  • Adds a basic integration test suite to prevent regressions.
  • Sets up GitHub Actions to run the tests automatically on every PR and push to the main branch.
  • Adds unit tests for relevant classes.

Closes #3.

@svenluijten
Copy link
Contributor Author

Let me know if you want (me) to add more unit tests @simonhamp! Most of the unit-testable code would just be testing setters/getters, and that feels pretty wasteful 😅

@svenluijten svenluijten marked this pull request as ready for review January 6, 2024 13:21
Copy link
Owner

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent. I just had one question about the GitHub Action workflow

.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Simon Hamp <simon.hamp@me.com>
@@ -0,0 +1,47 @@
on:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should note that I haven't been able to test this workflow. So it might require some tweaking after it's been merged into main.

Copy link
Owner

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it merged and see what happens!

@simonhamp simonhamp merged commit 073e129 into simonhamp:main Jan 7, 2024
@simonhamp
Copy link
Owner

@svenluijten it looks like the GitHub Actions are struggling to write the image files produced by the tests. Could be due to permissions?

https://github.com/simonhamp/the-og/actions/runs/7435530543/job/20230963612

@svenluijten svenluijten mentioned this pull request Jan 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use snapshots to automate testing
2 participants