-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite #5
Conversation
This allows users to override our settings with their own phpunit.xml.
Let me know if you want (me) to add more unit tests @simonhamp! Most of the unit-testable code would just be testing setters/getters, and that feels pretty wasteful 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent. I just had one question about the GitHub Action workflow
Co-authored-by: Simon Hamp <simon.hamp@me.com>
@@ -0,0 +1,47 @@ | |||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should note that I haven't been able to test this workflow. So it might require some tweaking after it's been merged into main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it merged and see what happens!
@svenluijten it looks like the GitHub Actions are struggling to write the image files produced by the tests. Could be due to permissions? https://github.com/simonhamp/the-og/actions/runs/7435530543/job/20230963612 |
This PR:
main
branch.Closes #3.