Better errors from visitable

This adds the actual error message from Ember's router to the (too generic) message from `visitable`. This is especially important when your test needs to know what kind of error was triggered. For example some tests might want to handle `TransitionAborted` errors differently, see emberjs/ember-test-helpers#332 (comment).
simonihmig · Feb 28, 2024 · 2eed933 · 2eed933
1 parent a290565
commit 2eed933
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/addon/src/properties/visitable.js b/addon/src/properties/visitable.js
@@ -138,8 +138,8 @@ export function visitable(path) {
 
     return getAdapter()
       .visit(fullPath)
-      .catch(() => {
-        throw new Error(`Failed to visit URL '${fullPath}'`);
+      .catch((e) => {
+        throw new Error(`Failed to visit URL '${fullPath}': ${e.message}`);
       });
   });
 }
diff --git a/test-app/tests/unit/-private/properties/visitable-test.ts b/test-app/tests/unit/-private/properties/visitable-test.ts
@@ -108,7 +108,7 @@ module('visitable', function (hooks) {
     } catch (e) {
       assert.strictEqual(
         e?.toString(),
-        `Error: Failed to visit URL '/non-existing-url/value'
+        `Error: Failed to visit URL '/non-existing-url/value': /non-existing-url/value
 
 PageObject: 'page.foo("[object Object]")'
   Selector: '.scope'`