Merge pull request #635 from simonihmig/empty-target

Make portal target render as empty
simonihmig · May 1, 2023 · 9d8257f · 9d8257f
2 parents 424a314 + 69d0b39
commit 9d8257f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/ember-stargate/src/components/portal-target.hbs b/ember-stargate/src/components/portal-target.hbs
@@ -2,6 +2,4 @@
   {{did-insert this.register}}
   {{will-destroy this.unregister}}
   ...attributes
->
-  {{yield this.count}}
-</div>
+>{{yield this.count}}</div>
diff --git a/test-app/tests/integration/components/portal-test.ts b/test-app/tests/integration/components/portal-test.ts
@@ -167,6 +167,14 @@ module('Integration | Component | portal', function (hooks) {
     assert.dom('#p2').hasText('foo');
   });
 
+  test('a portal target renders as an empty div', async function (assert) {
+    await render(hbs`
+      <PortalTarget @name="main" id="portal" />
+    `);
+
+    assert.dom('div#portal:empty').exists();
+  });
+
   test('a portal target renders only one portal by default', async function (assert) {
     await render(hbs`
       <PortalTarget @name="main" id="portal" />