-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Date and RegExp Objects #112
base: master
Are you sure you want to change the base?
Conversation
…Exp. If they are, they will not allow the code to treat them as an object and create a proxy of ObjectTreeNode. This allows the calling code to retreive a value as expected instead of a proxy with no value.
I'm no longer actively maintaining this library and unfortunately do not have the bandwidth to review/merge this change. Happy to pass permissions/ownership along to someone who can look after it. |
Thank you Chris,
As I'm using this library in my project right now, I would like permissions
so that I can update this project with this change and future changes.
Thank you,
Clark Woolsey
…On Wed, Dec 1, 2021 at 4:06 PM Chris Garrett ***@***.***> wrote:
I'm no longer actively maintaining this library and unfortunately do not
have the bandwidth to review/merge this change. Happy to pass
permissions/ownership along to someone who can look after it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6QVRS62IT6B73SXBANO4TUOY2WLANCNFSM5JEC46TA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hi Chris,
If you get a chance and give me permissions, I can go ahead and merge my
pull request.
Thank you,
Clark Woolsey
On Wed, Dec 1, 2021 at 5:46 PM Clark Woolsey ***@***.***>
wrote:
… Thank you Chris,
As I'm using this library in my project right now, I would like
permissions so that I can update this project with this change and future
changes.
Thank you,
Clark Woolsey
On Wed, Dec 1, 2021 at 4:06 PM Chris Garrett ***@***.***>
wrote:
> I'm no longer actively maintaining this library and unfortunately do not
> have the bandwidth to review/merge this change. Happy to pass
> permissions/ownership along to someone who can look after it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#112 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AD6QVRS62IT6B73SXBANO4TUOY2WLANCNFSM5JEC46TA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
@ctwoolsey I already have permissions on this repo, and could handle your PR. However I have some concerns here. First, it seems to be a bad practice to store mutable instances in the store. I am not a redux pro, but this is what their own docs say:
Second, even when that was acceptable, I would ask you to provide some tests for your changes. |
No description provided.