Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrapping even easier by avoiding custom Setup.hs #120

Merged
merged 3 commits into from
Mar 5, 2018

Conversation

hvr
Copy link
Member

@hvr hvr commented Feb 10, 2018

This PR does a couple of things:

  • Most importantly, converting the custom build-type to a simple build-type, which results in a more robust alex cabal package; and thus breaks up the dependency cycle between lib:Cabal and alex.
  • Use a fixed cpp implementation for performing the sdist template-preprocessing step (rather than rely on whichever cpp implementation the used Haskell implementation was configured to use). This also has the benefit that everyone gets the exact same template file sinstalled into their package db, rather than each installation having template files which subtly differ thanks to different C system headers, GHC headers/behaviour, or simply because of different cpp implementations.
  • Encode the intra-package dependency between test-suite and the alex component in the .cabal description, which allows us to simplify the test-logic and have cabal take care of the rest (the current one works with both "old-build" and new-build; the previous one worked only with "old-build")
  • Add more GHCs to the build-matrix, including GHC 7.4.2 as well as GHC 8.4.1-alpha
    (GHC 7.0.4 not added yet, as it would currently fail during the tests due to -Werror)

@hvr hvr force-pushed the pr/simple-alex branch 3 times, most recently from 678eaad to ca1fba1 Compare February 10, 2018 21:27
@hvr hvr changed the title WIP: Make bootstrapping even easier by avoiding custom Setup.hs Make bootstrapping even easier by avoiding custom Setup.hs Feb 10, 2018
Copy link
Member

@simonmar simonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on IRC: please add some instructions to the readme for people building directly from the git repo. Also is it possible to make it fail with a useful error message in that case?

@hvr
Copy link
Member Author

hvr commented Mar 1, 2018

@simonmar fyi, rendered extended README

@simonmar simonmar merged commit 68e1224 into haskell:master Mar 5, 2018
@hvr hvr deleted the pr/simple-alex branch March 5, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants