Implement %encoding directive #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the motivating use-case behind haskell#66 by implementing a new directive which is inspired by the existing %wrapper directive. The encoding string is matched case insensitive. Supported examples: %encoding "utf-8" %encoding "iso-8859-1" %encoding "UTF8" %encoding "Latin1" Moreover, some logic has been added to abort if the combination of CLI `--latin1` flags and %encoding directives contradict each other. For instance, setting `--latin1` on the command-line while requesting `%encoding "utf8"` in the Alex script causes Alex to abort with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the motivating use-case behind #66 by implementing a new
directive which is inspired by the existing %wrapper directive. The
encoding string is matched case insensitive. Supported examples:
Moreover, some logic has been added to abort if the combination of CLI
--latin1flags and %encoding directives contradict each other. Forinstance, setting
--latin1on the command-line while requesting%encoding "utf8"in the Alex script causes Alex to abort with an error.