Skip to content
This repository has been archived by the owner on Jan 16, 2020. It is now read-only.

Quit with Spotify #23

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Quit with Spotify #23

merged 5 commits into from
Sep 17, 2019

Conversation

lbordino
Copy link
Contributor

@lbordino lbordino commented Sep 6, 2019

No description provided.

@cfvescovo
Copy link
Contributor

Well done @lbordino!

@cfvescovo
Copy link
Contributor

It works flawlessly

@cfvescovo
Copy link
Contributor

@simonmeusel Could you review and merge this PR?

@simonmeusel
Copy link
Owner

simonmeusel commented Sep 16, 2019

Thank you for the contribution!

I'm now back and have access to computer again so I can review this.

I like the idea of closing Spotify with MuteSpotifyAds. What do you think of making it a separate quit button instead of another options? Because I think the option just adds another step.

So that there is

 - Close with Spotify
 - Quit

MuteSpotifyAds/SpotifyManager.swift Outdated Show resolved Hide resolved
MuteSpotifyAds/SpotifyManager.swift Outdated Show resolved Hide resolved
MuteSpotifyAds/AppDelegate.swift Outdated Show resolved Hide resolved
@simonmeusel simonmeusel mentioned this pull request Sep 16, 2019
2 tasks
@cfvescovo
Copy link
Contributor

@simonmeusel Yes, I think that this would be better.

@simonmeusel simonmeusel merged commit 49b0bb9 into simonmeusel:master Sep 17, 2019
@simonmeusel
Copy link
Owner

Thank you!

@simonmeusel
Copy link
Owner

Released with v1.11.0: https://github.com/simonmeusel/MuteSpotifyAds/releases

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants