Skip to content
This repository has been archived by the owner on Jan 16, 2020. It is now read-only.

Fix README.md and locales #29

Merged
merged 5 commits into from
Nov 24, 2019
Merged

Fix README.md and locales #29

merged 5 commits into from
Nov 24, 2019

Conversation

athdesk
Copy link
Contributor

@athdesk athdesk commented Nov 19, 2019

Adds missing languages' support in README.md and fixes a typo in the italian locale

fixes icons not showing up in Xcode (icons were corrupted after git clone, what happened here?)
@athdesk
Copy link
Contributor Author

athdesk commented Nov 20, 2019

closing due to pull request being incomplete, didn't test the locale

@athdesk athdesk closed this Nov 20, 2019
@athdesk
Copy link
Contributor Author

athdesk commented Nov 20, 2019

everything works now apparently, might have been a problem with my xcode instance
i'm not sure if this works for everyone, so please test this before pulling

@athdesk athdesk reopened this Nov 20, 2019
@simonmeusel simonmeusel changed the title Readme and it locale fixup Fix README.md and locales Nov 21, 2019
Copy link
Owner

@simonmeusel simonmeusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the README.md and the Itatlian lanuage.

But you also changed the formatting of one JSON file and changed the .png files. Please revert those changes.

Alternatively, I can pick out the changes and put them in a separate commit, if you want.

This PR contains a lot of different changes. In general it is recommended to only change specific parts in one PR.

hopefully uses the working icons from the github repo, and not the broken ones that were cloned on my computer
@athdesk
Copy link
Contributor Author

athdesk commented Nov 22, 2019

I reverted everything in the AppIcon.appiconset package, which were the changes to Contents.json and the image files
I should really have commited just README and the localisation files, instead i did git add . thinking it wouldn't affect the icon-related files, as all i did with them was replacing the corrupted ones that were cloned with copies from the github web service, ultimately i'm sorry for the inconvenience, and now the pull request is much cleaner

@simonmeusel
Copy link
Owner

Thank you. This is going to be in the next release.

@simonmeusel simonmeusel merged commit 8e389d0 into simonmeusel:master Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants