-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
fixes icons not showing up in Xcode (icons were corrupted after git clone, what happened here?)
closing due to pull request being incomplete, didn't test the locale |
everything works now apparently, might have been a problem with my xcode instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the README.md and the Itatlian lanuage.
But you also changed the formatting of one JSON file and changed the .png
files. Please revert those changes.
Alternatively, I can pick out the changes and put them in a separate commit, if you want.
This PR contains a lot of different changes. In general it is recommended to only change specific parts in one PR.
MuteSpotifyAds/Assets.xcassets/AppIcon.appiconset/Contents.json
Outdated
Show resolved
Hide resolved
MuteSpotifyAds/Assets.xcassets/AppIcon.appiconset/Contents.json
Outdated
Show resolved
Hide resolved
hopefully uses the working icons from the github repo, and not the broken ones that were cloned on my computer
I reverted everything in the |
Thank you. This is going to be in the next release. |
Adds missing languages' support in README.md and fixes a typo in the italian locale