Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting the date range from the chart #1471

Merged
merged 2 commits into from Feb 17, 2021

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jan 27, 2021

By dragging a region with the mouse

select

By dragging a region with the mouse
@simonmichael simonmichael added the web The hledger-web tool. label Feb 2, 2021
@simonmichael
Copy link
Owner

Great!

When zoomed in, it doesn't seem to always pick the dates you'd want. Eg to view the transactions on a single day, you'd expect that selecting a region that contains the dot will show the transactions on that day, but sometimes that day is excluded. See if you can reproduce, and maybe expand the selection in a smart way ?

@simonmichael simonmichael added the A-WISH Some kind of improvement request, hare-brained proposal, or plea. label Feb 2, 2021
@raboof
Copy link
Contributor Author

raboof commented Feb 16, 2021

to view the transactions on a single day, you'd expect that selecting a region that contains the dot will show the transactions on that day, but sometimes that day is excluded. See if you can reproduce, and maybe expand the selection in a smart way ?

Aah, indeed it was rounding down for the 'to' date, where it should been rounding up. Updated.

@simonmichael
Copy link
Owner

simonmichael commented Feb 17, 2021

That's much better. One more thing that may not be your fault, but would improve the feature I think. Testing with
make ghci-web, :main -f examples/sample.journal:

  • Click assets, select the two months enclosing the three central points.
    In the query field I see the span I selected, eg date:2008/4/30-2008/6/29.
    But the chart is shrunk to the points' span (6/1 to 6/3).
    It would be more intuitive if it showed the span that was selected.

@raboof
Copy link
Contributor Author

raboof commented Feb 17, 2021

One more thing that may not be your fault, but would improve the feature I think

I agree, but indeed pretty sure that's not directly related to this PR. Maybe let's create a separate issue for that?

@simonmichael
Copy link
Owner

simonmichael commented Feb 17, 2021 via email

@simonmichael simonmichael merged commit ad2ab3c into simonmichael:master Feb 17, 2021
@raboof
Copy link
Contributor Author

raboof commented Feb 17, 2021

Ok, would you mind creating it ?

Sure, #1485

Merging this one, thanks a lot !

Thanks for the merge!

simonmichael added a commit that referenced this pull request Feb 18, 2021
To minimise warnings. They got regenerated by a commit for #1471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. web The hledger-web tool.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants