-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bal: with --declared, include all declared accounts #1765
Conversation
Together with -E, this allows showing a balance for all accounts, both used and declared. I mainly want this for hledger-ui, but there's no harm in exposing it in the balance command as well. This is somewhat consistent with the accounts and payees commands.
)" This reverts commit a5e19b7. (It breaks filtering by account.)
Together with -E, this allows showing a balance for all accounts, both used and declared. I mainly want this for hledger-ui, but there's no harm in exposing it in the balance command as well. This is somewhat consistent with the accounts and payees commands.
Together with -E, this shows a balance for both used and declared accounts (excluding empty parent accounts, which are usually not wanted in list-mode reports). This is somewhat consistent with --declared in the accounts and payees commands, except for the leaf account restriction. The idea of this is to be able to see a useful "complete" balance report, even when you don't have transactions in all of your declared accounts yet. I mainly want this for hledger-ui, but there's no harm in exposing it in the balance CLI as well.
I reverted this merged PR after finding issues. I have just pushed a fixed version 6319d61. This was quite tricky; I think it's good now, but I'll wait at least a day, and any feedback is welcome. Commit message:
Doc:
|
Repushed [& merged] with fixes for bs/cf/is, showing the correct declared accounts in each subreport. No known open issues. |
Together with -E, this allows showing a balance for all accounts, both
used and declared. I mainly want this for hledger-ui, but there's no
harm in exposing it in the balance command as well. This is somewhat
consistent with the accounts and payees commands.