Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'length' of undefined #2

Closed
mtmfahath opened this issue Jun 11, 2018 · 6 comments
Closed

Uncaught TypeError: Cannot read property 'length' of undefined #2

mtmfahath opened this issue Jun 11, 2018 · 6 comments

Comments

@mtmfahath
Copy link

Uncaught TypeError: Cannot read property 'length' of undefined
at filterReviewsByMinRating (jquery-google-reviews.js:76)
at callback (jquery-google-reviews.js:115)
at places_impl.js:17
at places_impl.js:15
at util.js:208
at common.js:54
at Zl.f (common.js:15)
at Ml.j (common.js:54)
at Object.c [as _rgg3c0] (common.js:48)
at PlaceService.GetPlaceDetails?2sen-US&8sChIJHduuXU1VwokRBtBklimBjmQ&10e3&17m1&2e1&key=AIzaSyCJP67JWpe96_DILfz-_QpN3Gf_DltGqlI&callback=xdc._rgg3c0&token=99670:1

simonneutert pushed a commit that referenced this issue Jun 12, 2018
@simonneutert
Copy link
Owner

@mtmfahath your place does not have reviews, yet. Is that correct?
Please, post the Place-ID where the error was thrown, so I can debug easier 👍

@mtmfahath
Copy link
Author

<script> jQuery(document).ready(function($) { if ($("#google-reviews").length == 0) { return } //Find a placeID via https://developers.google.com/places/place-id $("#google-reviews").googlePlaces({ placeId: 'ChIJHduuXU1VwokRBtBklimBjmQ', }); }); </script>

simonneutert pushed a commit that referenced this issue Jun 12, 2018
@simonneutert
Copy link
Owner

simonneutert commented Jun 12, 2018

@mtmfahath as I guessed, no Reviews.

try this placeId: ChIJG2d5rI6xEmsRuLYl3xw9MqI

Code is fixed, simply download the new JS file 👍

@mtmfahath
Copy link
Author

mtmfahath commented Jun 12, 2018 via email

@simonneutert
Copy link
Owner

Happy to hear, you made the code better by reporting and collaborating. Have a good day 🦄

@mtmfahath
Copy link
Author

mtmfahath commented Jun 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants