Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapts to how vat_rates should be sent #114

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

simonneutert
Copy link
Owner

@simonneutert simonneutert commented Feb 4, 2024

vat_rate (for a line_item) should be sent as decimal.

Though it will work with a proper formatted String, too 🤷‍♂️

Please, see changes in this PR for implementation details.

Test

I should rerecord the ver cassettes, but decided to do it in a future release, as the implementation is still working as is.

Before

{
  vat_rate: "19%"
}

After

{
  vat_rate: 0.19
}

@simonneutert simonneutert force-pushed the adapt-to-change-in-papierkram-api branch from ebc0e7a to 0a74eb3 Compare February 4, 2024 09:04
@simonneutert simonneutert force-pushed the adapt-to-change-in-papierkram-api branch from ff614eb to aa7d385 Compare February 4, 2024 09:10
@simonneutert simonneutert merged commit 1d3533f into main Feb 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant