Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchRelationship fails on matching relationship properties #25

Open
amyprime opened this issue Mar 17, 2017 · 3 comments
Open

MatchRelationship fails on matching relationship properties #25

amyprime opened this issue Mar 17, 2017 · 3 comments

Comments

@amyprime
Copy link

MatchRelationship fails when attempting to match relationship properties.

You can see the problem in the test Neo4jClient.Extension.Test.Cypher.MatchRelationshipWithProperty. That is indeed the string that is generated, but it is not valid Cypher. "agenthomeAddressMatchKey" should be replaced with the property name and value, like the "id: 7" in the MatchEntity tests. An integration test would demonstrate the failure.

I believe the resolution is that in Neo4jClient.Extension.Cypher, MatchRelationshipWorker should make use of the dynamic cutdown like MatchWorker does.

@simonpinn
Copy link
Owner

Hi @amyprime ,

Yes, I agree. I don't think relationship properties were fully supported for matches, @neutmute do you remember? I'd want to add support for override properties, and support match attribute on the relationship entity.
I'll have a closer look, feel free to raise a PR @amyprime otherwise I'll get to it soon.

cheers

Simon

@simonpinn
Copy link
Owner

@amyprime / @neutmute just had a quick play something like #26 might be all that's needed, need to add some extra tests...

@amyprime
Copy link
Author

Hi @simonpinn, yes, I think your proposed fix should work. Thanks for looking into it!

neutmute added a commit to neutmute/Neo4jClient.Extension that referenced this issue Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants