Skip to content

Merge pull request #80 from simonrw/fix-ci #19

Merge pull request #80 from simonrw/fix-ci

Merge pull request #80 from simonrw/fix-ci #19

Triggered via push July 2, 2023 07:36
Status Failure
Total duration 52s
Artifacts

tracker.yml

on: push
Build binary
40s
Build binary
Fit to window
Zoom out
Zoom in

Annotations

1 error and 14 warnings
Build binary
Process completed with exit code 101.
the borrowed expression implements the required traits: rynamodb-compliance-tracker/src/database.rs#L52
warning: the borrowed expression implements the required traits --> rynamodb-compliance-tracker/src/database.rs:52:19 | 52 | .bind(&branch) | ^^^^^^^ help: change this to: `branch` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L282
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:282:17 | 282 | let table = unlocked_manager | _________________^ 283 | | .get_table_mut(&input.table_name) 284 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L224
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:224:17 | 224 | let table = unlocked_manager | _________________^ 225 | | .get_table(&input.table_name) 226 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L199
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:199:17 | 199 | let table = unlocked_manager | _________________^ 200 | | .get_table(&input.table_name) 201 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L153
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:153:17 | 153 | let table = unlocked_manager | _________________^ 154 | | .get_table(&input.table_name) 155 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
this async expression only awaits a single future: rynamodb/src/lib.rs#L42
warning: this async expression only awaits a single future --> rynamodb/src/lib.rs:42:31 | 42 | let handle = tokio::spawn(async { server.await }); | ^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `server` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_async_block = note: `#[warn(clippy::redundant_async_block)]` on by default
using `clone` on type `Region` which implements the `Copy` trait: rynamodb/src/table_manager.rs#L166
warning: using `clone` on type `Region` which implements the `Copy` trait --> rynamodb/src/table_manager.rs:166:24 | 166 | new.insert(region.clone(), new_tables); | ^^^^^^^^^^^^^^ help: try dereferencing it: `*region` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
the borrowed expression implements the required traits: rynamodb-compliance-tracker/src/database.rs#L52
warning: the borrowed expression implements the required traits --> rynamodb-compliance-tracker/src/database.rs:52:19 | 52 | .bind(&branch) | ^^^^^^^ help: change this to: `branch` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L282
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:282:17 | 282 | let table = unlocked_manager | _________________^ 283 | | .get_table_mut(&input.table_name) 284 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L224
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:224:17 | 224 | let table = unlocked_manager | _________________^ 225 | | .get_table(&input.table_name) 226 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L199
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:199:17 | 199 | let table = unlocked_manager | _________________^ 200 | | .get_table(&input.table_name) 201 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
unnecessary closure used to substitute value for `Option::None`: rynamodb/src/lib.rs#L153
warning: unnecessary closure used to substitute value for `Option::None` --> rynamodb/src/lib.rs:153:17 | 153 | let table = unlocked_manager | _________________^ 154 | | .get_table(&input.table_name) 155 | | .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?; | |__________------------------------------------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
this async expression only awaits a single future: rynamodb/src/lib.rs#L42
warning: this async expression only awaits a single future --> rynamodb/src/lib.rs:42:31 | 42 | let handle = tokio::spawn(async { server.await }); | ^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `server` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_async_block = note: `#[warn(clippy::redundant_async_block)]` on by default
using `clone` on type `Region` which implements the `Copy` trait: rynamodb/src/table_manager.rs#L166
warning: using `clone` on type `Region` which implements the `Copy` trait --> rynamodb/src/table_manager.rs:166:24 | 166 | new.insert(region.clone(), new_tables); | ^^^^^^^^^^^^^^ help: try dereferencing it: `*region` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default