Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde from 1.0.164 to 1.0.166 #82

Closed
wants to merge 1 commit into from

Bump serde from 1.0.164 to 1.0.166

bf3013c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Bump serde from 1.0.164 to 1.0.166 #82

Bump serde from 1.0.164 to 1.0.166
bf3013c
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 4, 2023 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.71.0-beta.4 (dbf31f17d 2023-06-24)
  • cargo 1.71.0-beta.4 (cfd3bbd8f 2023-06-08)
  • clippy 0.1.71 (dbf31f1 2023-06-24)

Annotations

Check warning on line 284 in rynamodb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> rynamodb/src/lib.rs:282:17
    |
282 |       let table = unlocked_manager
    |  _________________^
283 | |         .get_table_mut(&input.table_name)
284 | |         .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?;
    | |__________------------------------------------------------------------^
    |            |
    |            help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

Check warning on line 226 in rynamodb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> rynamodb/src/lib.rs:224:17
    |
224 |       let table = unlocked_manager
    |  _________________^
225 | |         .get_table(&input.table_name)
226 | |         .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?;
    | |__________------------------------------------------------------------^
    |            |
    |            help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

Check warning on line 52 in rynamodb-compliance-tracker/src/database.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> rynamodb-compliance-tracker/src/database.rs:52:19
   |
52 |             .bind(&branch)
   |                   ^^^^^^^ help: change this to: `branch`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 201 in rynamodb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> rynamodb/src/lib.rs:199:17
    |
199 |       let table = unlocked_manager
    |  _________________^
200 | |         .get_table(&input.table_name)
201 | |         .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?;
    | |__________------------------------------------------------------------^
    |            |
    |            help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations

Check warning on line 155 in rynamodb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> rynamodb/src/lib.rs:153:17
    |
153 |       let table = unlocked_manager
    |  _________________^
154 | |         .get_table(&input.table_name)
155 | |         .ok_or_else(|| ErrorResponse::ResourceNotFound { name: None })?;
    | |__________------------------------------------------------------------^
    |            |
    |            help: use `ok_or(..)` instead: `ok_or(ErrorResponse::ResourceNotFound { name: None })`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default

Check warning on line 42 in rynamodb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this async expression only awaits a single future

warning: this async expression only awaits a single future
  --> rynamodb/src/lib.rs:42:31
   |
42 |     let handle = tokio::spawn(async { server.await });
   |                               ^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `server`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_async_block
   = note: `#[warn(clippy::redundant_async_block)]` on by default

Check warning on line 166 in rynamodb/src/table_manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `Region` which implements the `Copy` trait

warning: using `clone` on type `Region` which implements the `Copy` trait
   --> rynamodb/src/table_manager.rs:166:24
    |
166 |             new.insert(region.clone(), new_tables);
    |                        ^^^^^^^^^^^^^^ help: try dereferencing it: `*region`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default