Small change needed in TTVFast.c to output correct RVs (Kat Deck + Lauren Weiss) #13
Comments
|
Thanks for this, I've released v0.2.1 of |
|
Thanks so much! How do I update ttvfast-python to respect the new change in TTVFast.c? I tried rerunning Thanks!
|
|
@sealauren are you installing from inside the git repository? If so you should be able do to: git pull
git submodule update
python setup.py installOtherwise if installing from pypi you should be able to do: pip install -U ttvfastIn fact that should work even when installing from the git repository.
In what way didn't it work? |
|
I don’t know how to get around this git error: $ git submodule update I did the pip install, but somehow when I call ttvfast.ttvfast() from python, it is using the old version of TTVFast.c. How does it find TTVFast.c?
|
Can you find out what the permissions are on the You can try deleting both the checked out directory and module directory and updating again: rm -r external/TTVFast
rm -r .git/modules/external/TTVFast
git submodule init
git submodule updateThis should clone a fresh copy. You may get the same permissions errors when trying to delete the directories, in which case as I said above work out which user/group owns the index.lock file. I don't know for sure, but I don't think this file should not exist - I don't have one anywhere in my repository.
I'm not sure about this. I've just released a new version on pypi v0.2.2. Can you try installing with import ttvfast
print(ttvfast.__version__)If it prints "0.2.2" then it includes the latest changes. If it prints anything else, or raises an exception then you have an old version. If you still have a problem with 0.2.2 then I need to have a deeper think. That code definitely includes your change. If you try all of the things I've suggested and it still doesn't work, could you send me a program that tests the new changes so I can do some debugging for myself? |
|
Hi Simon, I have managed to get to a point where I cannot call ttvfast from within python at all. Here is what I did:
git clone https://github.com/mindriot101/ttvfast-python.git python setup.py install Output: external/TTVFast/c_version/TTVFast.c: In function ‘read_helio_cartesian_params’: gcc -bundle -undefined dynamic_lookup -L/Users/lweiss/anaconda/lib -arch x86_64 -arch x86_64 build/temp.macosx-10.6-x86_64-2.7/src/ttvfast_wrapper.o build/temp.macosx-10.6-x86_64-2.7/external/TTVFast/c_version/TTVFast.o -L/Users/lweiss/anaconda/lib -o build/lib.macosx-10.6-x86_64-2.7/ttvfast/_ttvfast.so
unicorn:ttvfast-python lweiss$ py.test
unicorn:~ lweiss$ pip install ttvfast-python Do you have any idea what’s going on? I recently upgraded to macOS 10.12.1, and I am afraid that might be at the root of my problems.
|
|
Sorry I'm not at my computer this weekend, but the package is ttvfast Can you try installing that? On Sat, 5 Nov 2016, at 05:22, Lauren Weiss wrote:
|
|
Ok I think I understand what's going on.
This sounds like it installed ok.
I think this is because when you ran the tests, it looked for the first import ttvfast`it will probably work, provided the python you run is the same that you ran python setup.py developor pip install -e .and you will find the file
As I said in my previous response, the package is called Sorry I can't be much more of a help. |
|
Thanks so much Simon! Sent from my iPhone
|
|
@sealauren do I take it that this fixed your problem?! |
|
No not yet. I'll try to do some more digging around. Sent from my iPhone
|
|
Hi Simon, I’m still getting the problem that python cannot find ._ttvfast. Here is the error message: In [1]: import ttvfastImportError Traceback (most recent call last) /Users/lweiss/ttvfast-python/ttvfast/init.py in () ImportError: No module named _ttvfast I notice that I have a file in ttvfast called ._ttvfast.pyi, but nothing called ._ttvfast.py. I tried re-running setup.py (and pip), and here was the output: unicorn:ttvfast-python lweiss$ python setup.py install Installed /Users/lweiss/anaconda/lib/python2.7/site-packages/ttvfast-0.2.2-py2.7-macosx-10.6-x86_64.egg Lauren M. Weiss, PhD
|
|
Hi Simon, I figured it out, it was a problem in my path. All fixed! Thanks for your help updating TTVFast.c. Best wishes, Lauren M. Weiss, PhD
|
|
@sealauren awesome, thanks for making the package better! Closing this issue |
The text was updated successfully, but these errors were encountered: