Merge pull request #228 from simonsobs/param-check-bug-fix

Only perform check on param if value is given
simonsobs · Sep 22, 2021 · 13be6e8 · 13be6e8
2 parents 2d1f1c6 + de1401f
commit 13be6e8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ocs/ocs_agent.py b/ocs/ocs_agent.py
@@ -1164,9 +1164,9 @@ def get(self, key, default=ParamError(''), check=None, cast=None, type=None,
             if choices is not None:
                 if value not in choices:
                     raise ParamError(f"Param '{key}'={value} is not in allowed set ({choices})")
-        if check is not None:
-            if not check(value):
-                raise ParamError(f"Param '{key}' failed validity check (see docs?).")
+            if check is not None:
+                if not check(value):
+                    raise ParamError(f"Param '{key}' failed validity check (see docs?).")
         return value
 
     def batch(self, instructions, check_for_strays=True):