Skip to content

Commit

Permalink
Remove all references to 'prefix'
Browse files Browse the repository at this point in the history
'prefix' was removed from the HK data structure with HK v2.

closes #140
  • Loading branch information
BrianJKoopman committed Oct 22, 2020
1 parent b91c9dc commit 7f1d3be
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 23 deletions.
3 changes: 1 addition & 2 deletions ocs/agent/aggregator.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def save_to_block(self, data):
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': [2]},
'prefix': ''}
}
}
>>> prov.save_to_block(data)
Expand Down Expand Up @@ -395,7 +395,6 @@ def save_to_block(self, data):
except KeyError:
self.blocks[key] = ocs_feed.Block(
key, block['data'].keys(),
prefix=block['prefix']
)
b = self.blocks[key]

Expand Down
6 changes: 2 additions & 4 deletions ocs/ocs_feed.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
import re

class Block:
def __init__(self, name, keys, prefix=''):
def __init__(self, name, keys):
"""
Structure of block for a so3g IrregBlockDouble.
"""
self.name = name
self.prefix = prefix
self.timestamps = []
self.data = {
k: [] for k in keys
Expand Down Expand Up @@ -58,7 +57,6 @@ def encoded(self):
'block_name': self.name,
'data': {k: self.data[k] for k in self.data.keys()},
'timestamps': self.timestamps,
'prefix': self.prefix
}

class Feed:
Expand Down Expand Up @@ -211,7 +209,7 @@ def publish_message(self, message, timestamp=None):
try:
b = self.blocks[block_name]
except KeyError:
b = Block(block_name, message['data'].keys(), message.get('prefix', ''))
b = Block(block_name, message['data'].keys())
self.blocks[block_name] = b

if 'timestamp' in message:
Expand Down
34 changes: 17 additions & 17 deletions tests/test_aggregator.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_passing_float_in_provider_to_frame():
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': [2]},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -41,7 +41,7 @@ def test_passing_float_like_str_in_provider_to_frame():
'timestamps': [time.time()],
'data': {'key1': [1, 2],
'key2': ['1', 2]},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -66,7 +66,7 @@ def test_passing_non_float_like_str_in_provider_to_frame():
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -92,14 +92,14 @@ def test_sparsely_sampled_block():
'timestamps': [time.time()],
'data': {'key3': [0],
'key4': ['z']},
'prefix': ''}
}
}
provider.save_to_block(data)
data = {'test2': {'block_name': 'test2',
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -116,7 +116,7 @@ def test_sparsely_sampled_block():
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -130,14 +130,14 @@ def test_sparsely_sampled_block():
'timestamps': [time.time()],
'data': {'key3': [0],
'key4': ['z']},
'prefix': ''}
}
}
provider.save_to_block(data)
data = {'test2': {'block_name': 'test2',
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -156,7 +156,7 @@ def test_data_type_in_provider_save_to_block():
'timestamps': [time.time()],
'data': {'key1': [1],
'key2': ['1', 1]},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -176,7 +176,7 @@ def test_passing_invalid_data_field_name1():
'timestamps': [time.time()],
'data': {'invalid.key': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -198,7 +198,7 @@ def test_passing_invalid_data_field_name2():
'timestamps': [time.time()],
'data': {'__123invalid.key': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -222,7 +222,7 @@ def test_passing_too_long_data_field_name():
'timestamps': [time.time()],
'data': {'a'*1000: [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -245,7 +245,7 @@ def test_long_duplicate_name():
'timestamps': [time.time()],
'data': {'a'*1000: [1],
'a'*1001: ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -268,7 +268,7 @@ def test_reducing_to_duplicate_field_names():
'timestamps': [time.time()],
'data': {'an.invalid.key#': [1],
'an.invalid.key%': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -293,7 +293,7 @@ def test_space_replacement_in_field_names():
'timestamps': [time.time()],
'data': {'_an invalid key': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -314,7 +314,7 @@ def test_empty_field_name():
'timestamps': [time.time()],
'data': {'': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand All @@ -335,7 +335,7 @@ def test_enforced_field_which_becomes_empty():
'timestamps': [time.time()],
'data': {'123': [1],
'key2': ['a']},
'prefix': ''}
}
}
provider.save_to_block(data)

Expand Down

0 comments on commit 7f1d3be

Please sign in to comment.