Ignore and log invalid kwargs passed to Providers

fixes #148

ocs/agent/aggregator.py

@@ -6,6 +6,7 @@
 from typing import Dict
 
 import txaio
+txaio.use_twisted()
 
 from ocs import ocs_feed
 
@@ -151,7 +152,7 @@ class Provider:
             txaio logger
 
     """
-    def __init__(self, address, sessid, prov_id, frame_length=5*60, fresh_time=3*60):
+    def __init__(self, address, sessid, prov_id, frame_length=5*60, fresh_time=3*60, **kwargs):
         self.address = address
         self.sessid = sessid
         self.frame_length = frame_length
@@ -167,6 +168,8 @@ def __init__(self, address, sessid, prov_id, frame_length=5*60, fresh_time=3*60)
         self.last_refresh = time.time() # Determines if
         self.last_block_received = None
 
+        self.log.warn("Recieved unxpected keyword argument(s): {kwarg}", kwarg=kwargs)
+
     def encoded(self):
         return {
             'last_refresh': self.last_refresh,

tests/test_aggregator.py

@@ -363,3 +363,10 @@ def test_g3_cast():
     for x in incorrect_tests:
         with pytest.raises(TypeError) as e_info:
             g3_cast(x)
+
+# Tests related to #148
+def test_arbitrary_args_to_provider():
+    """Unexpected kwargs should be ignored."""
+    malformed_agg_params = {'not a valid key': 60,
+                            'frame length': 120}
+    provider = Provider('test_provider', 'test_sessid', 3, 1, **malformed_agg_params)