Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers crash if 'crossbar' is configured in site-config file #224

Closed
BrianJKoopman opened this issue Sep 1, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Projects

Comments

@BrianJKoopman
Copy link
Member

If there is a 'crossbar' configuration under any host in the ocs site config file, and that config file is used to startup Agents within Docker containers, those Agents will fail during site_config setup.

Example in site-config file:

  any-hostname: {
  'crossbar': {'config-dir': './dot_crossbar/'},
    'agent-instances': []
  }

Resulting crash:

2021-09-01T20:53:44+0000 Traceback (most recent call last):
2021-09-01T20:53:44+0000   File "aggregator_agent.py", line 156, in <module>
2021-09-01T20:53:44+0000     args = site_config.parse_args(agent_class='AggregatorAgent',
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 700, in parse_args
2021-09-01T20:53:44+0000     site, host, instance = get_config(pre_args, agent_class=agent_class)
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 424, in get_config
2021-09-01T20:53:44+0000     site_config = SiteConfig.from_yaml(site_file)
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 62, in from_yaml
2021-09-01T20:53:44+0000     self = cls.from_dict(data)
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 53, in from_dict
2021-09-01T20:53:44+0000     self.hosts[k] = HostConfig.from_dict(v, parent=self, name=k)
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 110, in from_dict
2021-09-01T20:53:44+0000     self.crossbar = CrossbarConfig.from_dict(data.get('crossbar'))
2021-09-01T20:53:44+0000   File "/app/ocs/ocs/site_config.py", line 139, in from_dict
2021-09-01T20:53:44+0000     raise RuntimeError("Unable to locate crossbar binary")
2021-09-01T20:53:44+0000 RuntimeError: Unable to locate crossbar binary
@BrianJKoopman BrianJKoopman added the bug Something isn't working label Sep 1, 2021
@BrianJKoopman BrianJKoopman added this to Needs triage in Bug Fixes via automation Sep 1, 2021
@mhasself mhasself self-assigned this Nov 3, 2021
@BrianJKoopman
Copy link
Member Author

Fixed in #241.

Bug Fixes automation moved this from Needs triage to Closed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Bug Fixes
  
Closed
Development

No branches or pull requests

2 participants