Core updates, prelude for major ocsbow #241
Conversation
Marking these as private may be helpful to users. However the docstrings are useful as reference material for people using clients.
Perhaps we should deprecate the other get_* functions, and eventually remove them.
…=... I have checked all Agent use of this function and I do not expect any surprising side effects.
Docstring already claimed as much ... defaults to [].
This is backwards compatible but should provide a bit more structure for those who want it.
ocs/ocs_client.py
Outdated
| for name, _, encoded in self._client.get_tasks(): | ||
| for name, session, encoded in self._api['tasks']: | ||
| setattr(self, _opname_to_attr(name), | ||
| _get_op('task', name, encoded, self._client)) | ||
|
|
||
| for name, _, encoded in self._client.get_processes(): | ||
| for name, session, encoded in self._api['processes']: |
There was a problem hiding this comment.
Is session useful in these cases? (Or will it be useful in #234?) It used to get passed to _get_op(), but it was never used, so I removed it in a8c8f9a, which is why these are currently _. I get this is less readable, so maybe _session instead?
This also makes me wonder if session needs to be returned from .get_api(). (Not saying we have to change this in this PR, but just stirring the discussion.)
There was a problem hiding this comment.
Oh, sorry about that. I had a bad merge affecting those lines... will revert it.
Session is useful to have ... I might use it in ocsbow or in HostManager web. It is not strictly "api", but it's nice to minimize the number of calls needed to et all the Agent info (static and dynamic).
Description
Innocuous (I think) improvements that are helpful to upcoming ocsbow/HostManager revamp. This will be followed by a major ocsbow/HostManager PR that has only one additional core change (adding 'manage' as an instance argument in site_config).
Includes:
How Has This Been Tested?
Used for extensive ocsbow work. All tests pass.
Types of changes
Checklist:
developbranch.