Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g32influx bug fix and file check skip #162

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

BrianJKoopman
Copy link
Member

Description

Fix a small bug and add the ability to skip the file check against the database.

Motivation and Context

The bug caused crashes when the error the bug was in was raised. Also, since the files weren't changing during the hk v2 update having the script check the database for file changes/new files was just a needless, and sometimes slow, process. The flag allows us to just skip it.

How Has This Been Tested?

This was implemented and used during the UCSD hk v2 update.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman BrianJKoopman added bug Something isn't working enhancement New feature or request labels Aug 13, 2020
@BrianJKoopman BrianJKoopman added this to the v0.7.1 milestone Aug 13, 2020
@BrianJKoopman BrianJKoopman merged commit 7c9abe6 into develop Aug 25, 2020
@BrianJKoopman BrianJKoopman deleted the g32influx-patch branch August 25, 2020 13:12
@BrianJKoopman BrianJKoopman mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant