Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow str type in Feed #164

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Allow str type in Feed #164

merged 2 commits into from
Sep 8, 2020

Conversation

BrianJKoopman
Copy link
Member

Description

The switch to using the G3Timesample object to store data instead of IrregBlockDouble in #128 allows us to store strings in a G3String. The OCS Feeds check the type of data being passed to them and previously strings were restricted. This allows them to be published on Feeds.

Motivation and Context

The M1000 Agent being developed in socs will pass string descriptions of the state of the hardware along with integers which encode those strings. Without this patch the strings cause an error to be raised when publishing to the Feed.

How Has This Been Tested?

Tests updated to try passing a string to the feed (and pass locally.) I've also been developing the M1000 Agent and passing strings from it based on a patched OCS with this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's get this in... need it for ACU, too.

@BrianJKoopman BrianJKoopman merged commit 26ded5a into develop Sep 8, 2020
@BrianJKoopman BrianJKoopman deleted the str_type_in_feeds branch September 8, 2020 12:16
@BrianJKoopman BrianJKoopman added the bug Something isn't working label Oct 29, 2020
@BrianJKoopman BrianJKoopman mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants