Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip installed so3g in GH Action workflows #256

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

BrianJKoopman
Copy link
Member

Description

Now that so3g is easily pip installable this allows us to do several things:

  • Install so3g within the GH Actions workflows directly, meaning we can drop the use of docker containers for running tests that depend on spt3g/so3g.
  • Remove the spt3g marker on our tests used to select only those test which do or do not depend on spt3g/so3g. We now just insist that so3g is installed for testing by adding it to the requirements/testing.txt file. Associated with this we no longer check for successful imports as a dependency for running those tests, meaning we can also drop the pytest-dependency module as a requirement.

I've also listed so3g as an optional requirement via extras_install in setup.py.

Motivation and Context

Take advantage of the fact that so3g is now on PyPI and easily installable.

How Has This Been Tested?

I've tested the test locally, and they will run in this PR/have run on these commits. The deploy develop and deploy workflow changes are currently untested, though mimic those changes made in the pytest workflow.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

Now that we do this we can also remove the containerized test running, instead
running directly in the workflow environment.
These are now easy to install with pip, so we shouldn't have to navigate around
not having them.
No longer needed now that we've removed the so3g dependency check in our
tests.
@BrianJKoopman BrianJKoopman added the enhancement New feature or request label Feb 3, 2022
@BrianJKoopman BrianJKoopman self-assigned this Feb 3, 2022
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@BrianJKoopman BrianJKoopman merged commit 05dea0b into develop Feb 3, 2022
@BrianJKoopman BrianJKoopman deleted the koopman/use-pip-so3g-in-workflows branch February 3, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants