Cherry-pick better agent handling and logs from host manager work #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally from 1c993ad. Slightly modified in that the changes are applied to code in a different file that was moved. Also wrapped long lines.
This was referenced Jun 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally from 1c993ad, but was dropped during the work in #234.
Slightly modified in that the changes are applied to code in a different file that was moved. Also wrapped long lines.
Motivation and Context
Currently, it can be difficult to debug when an Agent doesn't actually startup using the agent runner fixture. This solves that by printing the stdout and stderr for the Agent.
How Has This Been Tested?
Used locally while debugging tests for a new Agent in socs.
Types of changes
Checklist:
developbranch.