Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passes environment variables to docker subprocesses #268

Merged
merged 1 commit into from
May 23, 2022

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented May 17, 2022

Small change to the host-manager agent so that it passes the environment through to subprocess calls.

Motivation and Context

This is required for calling docker services that use environment variables.

How Has This Been Tested?

Tested by running the host_manager at Penn

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@jlashner jlashner requested a review from mhasself May 17, 2022 17:37
@BrianJKoopman BrianJKoopman merged commit bc67d61 into develop May 23, 2022
@BrianJKoopman BrianJKoopman deleted the hm_subprocess_env branch May 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants